fix(api): isole la base de test de la base de dev
Incident : lancer `pnpm test` (apps/api) truncait la vraie base de dev locale — `test-support/reset-db.ts`'s `resetDatabase()` fait un `TRUNCATE ... CASCADE` sur quasiment tout le schéma (dont `house`/`house_source`) avant *chaque* test, et `.env`/tests partageaient le même `DATABASE_URL` (un seul fichier `.env`, `NODE_ENV=test` ne changeait rien). Deux lancements du test suite cette session ont ainsi effacé le foyer, le compte et les activations de sources d'un utilisateur en train de tester l'app en local — perte réelle, aucune récupération possible (TRUNCATE, pas de sauvegarde). - `config/env.ts` charge désormais `.env.test` (pas `.env`) quand `NODE_ENV=test` — `.env.test` (local, non commité, comme `.env`) pointe vers une base Postgres séparée (`batchcooking_test`, même serveur/identifiants que la base de dev, juste une base différente). `.env.test.example` documente comment la créer. - `resetDatabase()` refuse maintenant de tourner si `NODE_ENV !== "test"` ou si `DATABASE_URL` ne contient pas "test" — garde-fou supplémentaire si `.env.test` est un jour absent/mal configuré, pour ne plus jamais reproduire cet incident même en cas d'erreur de configuration. - `.gitignore` autorise `.env.test.example` (déjà ignoré via `.env.*`, comme `.env.example` l'est déjà pour `.env`). Vérifié : snapshot de la base de dev (houses/house_sources/users) avant/ après un lancement complet de `pnpm test` — identique, base de dev intacte. 282 tests toujours au vert, contre la nouvelle base de test. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
parent
be0d885269
commit
61ac2993db
4 changed files with 53 additions and 1 deletions
1
.gitignore
vendored
1
.gitignore
vendored
|
|
@ -69,6 +69,7 @@ web_modules/
|
||||||
.env
|
.env
|
||||||
.env.*
|
.env.*
|
||||||
!.env.example
|
!.env.example
|
||||||
|
!.env.test.example
|
||||||
|
|
||||||
# parcel-bundler cache (https://parceljs.org/)
|
# parcel-bundler cache (https://parceljs.org/)
|
||||||
.cache
|
.cache
|
||||||
|
|
|
||||||
15
apps/api/.env.test.example
Normal file
15
apps/api/.env.test.example
Normal file
|
|
@ -0,0 +1,15 @@
|
||||||
|
NODE_ENV=test
|
||||||
|
PORT=3000
|
||||||
|
# Must point at a *different* database than your `.env`'s — `pnpm test`
|
||||||
|
# (test-support/reset-db.ts's `resetDatabase()`) TRUNCATEs almost every
|
||||||
|
# table before each test. Pointing this at the same database `pnpm dev`
|
||||||
|
# uses will wipe real local data on every test run. Easiest setup: same
|
||||||
|
# Postgres server/credentials as `.env`, just a different database name —
|
||||||
|
# create it once with e.g.:
|
||||||
|
# pnpm exec prisma db execute --url "postgresql://USER:PASSWORD@localhost:PORT/postgres?schema=public" --file - <<< "CREATE DATABASE batchcooking_test;"
|
||||||
|
# DATABASE_URL="postgresql://USER:PASSWORD@localhost:PORT/batchcooking_test?schema=public" pnpm exec prisma migrate deploy
|
||||||
|
DATABASE_URL="postgresql://changeme:changeme@localhost:5432/batchcooking_test?schema=public"
|
||||||
|
|
||||||
|
# Required, no default on purpose — generate your own, e.g.:
|
||||||
|
# node -e "console.log(require('crypto').randomBytes(48).toString('hex'))"
|
||||||
|
JWT_SECRET=changeme-generate-a-real-random-secret-at-least-32-chars
|
||||||
|
|
@ -1,6 +1,18 @@
|
||||||
import "dotenv/config";
|
import dotenv from "dotenv";
|
||||||
import { z } from "zod";
|
import { z } from "zod";
|
||||||
|
|
||||||
|
// Loads `.env.test` instead of `.env` when running the test suite
|
||||||
|
// (NODE_ENV=test, set by `cross-env` in package.json's `test` script —
|
||||||
|
// already present in `process.env` by the time this module runs, since
|
||||||
|
// `cross-env` sets it before invoking node/tsx at all). Keeps
|
||||||
|
// `resetDatabase()` (test-support/reset-db.ts, which TRUNCATEs almost
|
||||||
|
// every table before each test) pointed at a dedicated test database,
|
||||||
|
// never whatever `pnpm dev` actually uses — running the test suite once
|
||||||
|
// already wiped a real local dev database this way (`.env`/`.env.test`
|
||||||
|
// sharing one `DATABASE_URL`), see `.env.test.example` for how to set the
|
||||||
|
// separate test database this now requires.
|
||||||
|
dotenv.config({ path: process.env.NODE_ENV === "test" ? ".env.test" : ".env" });
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Schema for every environment variable the API reads. Parsing (below)
|
* Schema for every environment variable the API reads. Parsing (below)
|
||||||
* fails fast at startup if something required is missing/invalid, instead
|
* fails fast at startup if something required is missing/invalid, instead
|
||||||
|
|
|
||||||
|
|
@ -1,7 +1,30 @@
|
||||||
|
import { env } from "../src/config/env.js";
|
||||||
import { prisma } from "../src/db/prisma.js";
|
import { prisma } from "../src/db/prisma.js";
|
||||||
import { syncRecipeSources } from "../src/db/recipe-source-sync.js";
|
import { syncRecipeSources } from "../src/db/recipe-source-sync.js";
|
||||||
import { seedReferenceData } from "../src/db/reference-seed-data.js";
|
import { seedReferenceData } from "../src/db/reference-seed-data.js";
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Refuses to run outside a database that's obviously a test one — belt and
|
||||||
|
* braces alongside `config/env.ts` loading `.env.test` (not `.env`) under
|
||||||
|
* `NODE_ENV=test`: this already wiped a real local dev database once, when
|
||||||
|
* both env files shared one `DATABASE_URL`. `resetDatabase()` below
|
||||||
|
* TRUNCATEs almost the entire schema before every single test, so a
|
||||||
|
* misconfigured/missing `.env.test` must fail loudly here rather than
|
||||||
|
* silently truncate whatever `DATABASE_URL` happens to be set.
|
||||||
|
*/
|
||||||
|
function assertRunningAgainstTestDatabase() {
|
||||||
|
if (env.NODE_ENV !== "test") {
|
||||||
|
throw new Error(
|
||||||
|
`resetDatabase() TRUNCATEs almost the whole schema — refusing to run outside NODE_ENV=test (currently "${env.NODE_ENV}").`,
|
||||||
|
);
|
||||||
|
}
|
||||||
|
if (!env.DATABASE_URL?.includes("test")) {
|
||||||
|
throw new Error(
|
||||||
|
`resetDatabase() refuses to run against a DATABASE_URL that doesn't look like a test database (got "${env.DATABASE_URL}", expected it to contain "test") — see .env.test.example.`,
|
||||||
|
);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// Single TRUNCATE ... CASCADE covers FK ordering and resets identity
|
// Single TRUNCATE ... CASCADE covers FK ordering and resets identity
|
||||||
// sequences — used between tests/scenarios to start from a clean slate.
|
// sequences — used between tests/scenarios to start from a clean slate.
|
||||||
// Re-seeds the Diet/Category/Allergy/Unit reference data right after
|
// Re-seeds the Diet/Category/Allergy/Unit reference data right after
|
||||||
|
|
@ -12,6 +35,7 @@ import { seedReferenceData } from "../src/db/reference-seed-data.js";
|
||||||
// reflect whatever adapters this test run happens to have registered
|
// reflect whatever adapters this test run happens to have registered
|
||||||
// (usually none — see recipe-source-registry.ts).
|
// (usually none — see recipe-source-registry.ts).
|
||||||
export async function resetDatabase() {
|
export async function resetDatabase() {
|
||||||
|
assertRunningAgainstTestDatabase();
|
||||||
await prisma.$executeRawUnsafe(`
|
await prisma.$executeRawUnsafe(`
|
||||||
TRUNCATE TABLE
|
TRUNCATE TABLE
|
||||||
"user_profile_allergy", "user_preference", "allergy", "category",
|
"user_profile_allergy", "user_preference", "allergy", "category",
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue