name: CI # Every push, on every branch — not just main — so build breakage shows up # on the first commit of a branch, not only once a PR targets main. No # separate pull_request trigger: for a PR from a branch on this same repo, # push already fires on that branch, and GitHub attaches the run to the PR # by commit SHA regardless of which event triggered it — adding # pull_request too would just run every job twice per push. (Re-add it, # scoped to forks, only if this repo starts accepting fork PRs — push # events from a fork never reach here.) on: push: env: # Only the `test` job ever opens a database connection, and it *overwrites* # this value at runtime (see its "Start Postgres" step) with a per-run # hostname. This entry stays for one reason: `build`'s `pnpm install` runs # `prisma generate` (apps/api `postinstall`), which wants DATABASE_URL to # be present and syntactically valid — it never dials the host, so the # literal `postgres` here need not resolve anywhere. # # Why the `test` job runs Postgres as a plain `docker run` and not a # `services:` block: this repo's Forgejo `act` runner does not keep a # `services:` container as the *same* instance across a job's steps, so # `migrate deploy` would land the schema in one Postgres and `pnpm --filter # api test`'s `beforeAll` would then hit an empty one ("table … does not # exist" right after "migrations successfully applied"). One long-lived # container in the job, shared by every step, removes that failure mode. DATABASE_URL: "postgresql://ci:ci@postgres:5432/batchcooking_ci?schema=public" # Test-only secret, never used outside CI — real deployments must set their own. JWT_SECRET: "ci-only-secret-not-used-anywhere-else-32chars+" # Same reasoning as JWT_SECRET above — lets tech-step-worker.routes.test.ts # exercise the success path (matching secret), not just the "unset" # rejection every environment that doesn't set this gets by default. INTERNAL_WORKER_SECRET: "ci-only-worker-secret-not-used-anywhere-else-32chars+" # Same reasoning — lets admin-auth.test.ts exercise the admin login # success path + the requireAdmin-guarded routes, not just the "no admin # secret configured -> 401" path. ADMIN_JWT_SECRET: "ci-only-admin-secret-not-used-anywhere-else-32chars+" # Shared between the `test` job's own uvicorn step (below) and apps/api's # IntentServiceClient — that step runs `uvicorn` as a plain background # process (not a `services:` block or even a container) because CI can # only pull a published image, not build # services/tech-step-intent-service/Dockerfile from this checkout. INTENT_SERVICE_BASE_URL: "http://localhost:8000" INTENT_SERVICE_SECRET: "ci-only-intent-secret-not-used-anywhere-else-32chars+" jobs: # Five independent jobs, no needs: between them — each starts in parallel # and reports as its own check, instead of the previous single chained # "lint-and-test then e2e" pipeline. lint: runs-on: ubuntu-latest steps: - uses: https://github.com/actions/checkout@v4 - uses: pnpm/action-setup@v4 - uses: https://github.com/actions/setup-node@v4 with: node-version: 22 cache: pnpm - run: pnpm install --frozen-lockfile - run: pnpm lint test: runs-on: ubuntu-latest # Runaway ceiling, not a target: the job takes ~16-19 min normally (runs # 117-121). Mocha runs with no `--exit` (`apps/api/.mocharc.json`), so a # single leaked handle would otherwise hang this job until the runner's # global timeout — a `test` job zombied for ~1h once before being # cancelled by hand. 40 min leaves roughly 2x headroom for a slow / # contended runner while still capping a hang at well under that hour. timeout-minutes: 40 steps: - name: Install curl and the docker CLI run: | apt-get update && apt-get install -y curl docker.io # Postgres as a plain background container instead of a `services:` # block — see this workflow's top-level `env.DATABASE_URL` comment for # why. The runner mounts the docker socket and runs every job on one # shared user-defined network, so a `--name` sibling resolves by name; # the network is discovered from the job container itself rather than # hardcoded. # # The container name carries the run id (`postgres-${GITHUB_RUN_ID}`) # rather than a bare `postgres` *because* that network is shared by # every job on this runner, across all branches. With a fixed name, # two `test` jobs overlapping — a feature push landing within minutes # of a `main` merge — both connected to the *same* container, and # their `prisma migrate deploy` + `seedReferenceData` (root Mocha # `beforeAll`) raced: `Unique constraint failed on the fields: (key)` # in `seedReferenceData`, "No pending migrations to apply" when there # should be some, `tech_step`/`diet` reference-row id shifts (+5) # breaking unrelated assertions. Hit three times in one session (PRs # #47, #53, #54), each needing an empty-commit re-trigger once the # runner was idle. A GitHub-style `concurrency:` group on this job is # the natural fix, but this Forgejo (9.0.3) predates Actions # `concurrency` support entirely — it arrived in Forgejo v14 / Gitea # 1.26 and the key is silently ignored on anything older. A per-run # container name reaches the same end (no two runs share a database) # with zero runner support required; the `if: always()` teardown step # at the end of the job, plus the age-gated reap below, keep these # per-run containers from piling up on the runner host. - name: Start Postgres in the background run: | pg_host="postgres-${GITHUB_RUN_ID}" # Best-effort reap of per-run Postgres containers left behind by a # `test` job that was force-killed before its teardown step could # run (SIGKILL skips `if: always()` steps). Age-gated well above # this job's `timeout-minutes`, so a slower *concurrent* `test` # job's container is never in range. reap_before=$(( $(date +%s) - 7200 )) for c in $(docker ps -aq --filter "name=postgres-"); do started="$(docker inspect -f '{{.State.StartedAt}}' "$c" 2>/dev/null)" || continue started_epoch="$(date -d "$started" +%s 2>/dev/null)" || continue if [ "$started_epoch" -lt "$reap_before" ]; then echo "reaping abandoned Postgres container $c (started $started)" docker rm -f "$c" >/dev/null 2>&1 || true fi done net="$(docker inspect "$(hostname)" \ --format '{{range $k, $_ := .NetworkSettings.Networks}}{{$k}} {{end}}' \ | awk '{print $1}')" echo "job network: ${net:?could not determine the job container network}" docker rm -f "$pg_host" >/dev/null 2>&1 || true docker run -d --name "$pg_host" --network "$net" \ -e POSTGRES_USER=ci -e POSTGRES_PASSWORD=ci -e POSTGRES_DB=batchcooking_ci \ postgres:16-alpine # Hand this run's hostname to every later step (prisma migrate # deploy, pnpm --filter api test) — this line overrides the # workflow-level env.DATABASE_URL, whose `postgres` host no longer # resolves. echo "DATABASE_URL=postgresql://ci:ci@${pg_host}:5432/batchcooking_ci?schema=public" >> "$GITHUB_ENV" for _ in $(seq 1 60); do docker exec "$pg_host" pg_isready -U ci -d batchcooking_ci && exit 0 sleep 2 done echo "Postgres did not become ready in time" >&2 docker logs "$pg_host" || true exit 1 - uses: https://github.com/actions/checkout@v4 - uses: pnpm/action-setup@v4 - uses: https://github.com/actions/setup-node@v4 with: node-version: 22 cache: pnpm - uses: https://github.com/astral-sh/setup-uv@v5 with: python-version: "3.12" enable-cache: true # A `services:` block can only pull an already-published image — it # can't build services/tech-step-intent-service/Dockerfile from this # checkout. Running `uvicorn` as a plain background step instead: it # keeps running for the rest of this job (steps in one job share the # same process tree), and `pnpm --filter api test` below needs a real # instance to talk to per this repo's "never mock an internal service" # test convention — same "real dependency, started by the job itself" # posture as the Postgres step above, not a mock HTTP server. - name: Install services/tech-step-intent-service working-directory: services/tech-step-intent-service run: uv sync --frozen - name: Start services/tech-step-intent-service in the background working-directory: services/tech-step-intent-service run: | uv run uvicorn intent_service.main:app --host 0.0.0.0 --port 8000 & # `/health` only returns 200 once this service has finished # training itself from scratch (no model ever persisted to disk — # see its own README) — measured at ~3min combined (fr+en) against # the current ~74-technique corpus, down from ~930s once # `spacy.TextCatBOW.v3`'s `length` stopped being left at its # 262144 default (see `_TEXTCAT_MODEL_LENGTH` in # `locale_pipeline.py`, and docker-compose.yml's healthcheck for # the same reasoning). The timeout stays well above that: it's a # ceiling for a slow/contended runner, not a target. timeout 600 bash -c 'until curl -sf http://localhost:8000/health > /dev/null; do sleep 2; done' - run: pnpm install --frozen-lockfile - run: pnpm --filter api exec prisma migrate deploy - run: pnpm --filter api test # Remove this run's Postgres even when a step above failed or the job # hit its `timeout-minutes` — with a per-run name nothing else ever # reuses or cleans it, and a bare `docker run` sibling outlives the job # container. `|| true`: teardown must never itself fail the job. A job # killed outright (SIGKILL, no `always()` step) is caught by the # age-gated reap in "Start Postgres" on a later run. - name: Stop this run's Postgres if: always() run: docker rm -f "postgres-${GITHUB_RUN_ID}" >/dev/null 2>&1 || true intent-service-test: runs-on: ubuntu-latest steps: - uses: https://github.com/actions/checkout@v4 - uses: https://github.com/astral-sh/setup-uv@v5 with: python-version: "3.12" enable-cache: true - name: Install services/tech-step-intent-service working-directory: services/tech-step-intent-service run: uv sync --frozen - name: Run pytest working-directory: services/tech-step-intent-service run: uv run pytest -q build: runs-on: ubuntu-latest steps: - uses: https://github.com/actions/checkout@v4 - uses: pnpm/action-setup@v4 - uses: https://github.com/actions/setup-node@v4 with: node-version: 22 cache: pnpm - run: pnpm install --frozen-lockfile - run: pnpm build e2e: runs-on: ubuntu-latest steps: - uses: https://github.com/actions/checkout@v4 - name: Install Xvfb and Cypress dependencies run: | apt-get update apt-get install -y xvfb libgtk2.0-0 libgtk-3-0 libgbm-dev libnotify-dev libnss3 libxss1 libasound2 libxtst6 xauth dbus-x11 - uses: pnpm/action-setup@v4 - uses: https://github.com/actions/setup-node@v4 with: node-version: 22 cache: pnpm - name: Cache Cypress binary uses: https://github.com/actions/cache@v4 with: path: ~/.cache/Cypress key: cypress-${{ runner.os }}-${{ hashFiles('pnpm-lock.yaml') }} - run: pnpm install --frozen-lockfile # pnpm install doesn't reliably trigger Cypress's postinstall binary # download (see apps/web's cypress caveat in the README) — install it # explicitly so `cypress run` finds it. - run: pnpm --filter web exec cypress install - name: Run E2E tests env: HOST: "0.0.0.0" run: pnpm --filter web e2e # No dev server needed here — Cypress spins up its own Vite dev # server internally for component testing (see cypress.config.ts's # `component.devServer`), unlike `e2e` above which needs the real app # running first. - run: pnpm --filter web cy:run:component