15 commits

Author	SHA1	Message	Date
Nicolas	b2310216ce	Fix settings menu visibility bug; make the music player a persistent bar ... Fix: player settings menu stuck permanently open ---------------------------------------------- .hide { display: none; } and Player.css's .settingsPanel { display: flex; ... } are both single-class selectors - equal specificity - so whichever one esbuild happened to bundle later into app.css won the `display` property on an element carrying both classes. Player.css's own display:flex always landed after base.css's .hide, so #settingsPanel showed regardless of the hide class ever being toggled - the toggle logic itself was correct the whole time, it just had no visible effect. Fixed at the utility class, not the one call site: `.hide` now uses `display: none !important`, which wins a same-specificity tie regardless of bundling order - closes off the whole bug class, since several other components already set their own `display` for a visible state. Feature: music player is now a persistent bottom bar, not a page ------------------------------------------------------------------ The music player was its own route (/party/:id -> views/musicPlayer/), which meant navigating anywhere else - the sidebar, an album to queue up more tracks - tore the whole thing down (router.ts calls a route's cleanup, which used to call leaveParty, on every hash change). No way to browse and listen at the same time. - client/src/musicBar/MusicBar.ts (new): a Shell-level singleton, mounted once into a #musicBar element that's a sibling of #mainContent, never touched by route changes. Renders as a fixed bottom bar. Exposes initMusicBar/joinMusicParty/leaveMusicParty instead of the router's render()-returns-cleanup pattern, since it never registers as a route. - views/player/Player.ts's dispatcher: a music party no longer renders a page - it calls joinMusicParty() and bounces back to /home (a no-op for every reachable call site except album's). A video party now calls leaveMusicParty() first (harmless no-op if nothing's active) - starting or joining a video watch party always leaves the listen party, since every party-join call site already funnels through this one dispatcher. - views/album/Album.ts: the last per-track "start a party" UI now that the music player's own inline browse panel is gone (browsing just means navigating there normally). Each track's button starts a new party or adds to whichever one is already active, decided by getActiveMusicPartyId() at CLICK time (not render time) so the action taken is always correct even if the label is momentarily stale; every button is relabeled in place after a successful click. Starting a party from here no longer navigates away at all. - views/musicPlayer/ deleted entirely (MusicPlayer.ts/.html/.css) - superseded by musicBar/. - Comment updates in global.d.ts/presence.css/trackList.css/party.ts/ types.ts that named the old module by path. Verified both fixes by rebuilding and driving the real compiled bundle through a local static server, with fetch/window.io/window.Hls mocked: starting a party from an album track leaves the sidebar/page in place and relabels the other tracks; adding a track posts to the already-active party's id; navigating into a video party hides the bar, disconnects its socket, and posts a real leave for the music party before the video player renders; the settings gear opens/closes correctly for the host in that same run. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-09-14 10:43:12 +02:00
Nicolas	fc678b313c	Add a real server test suite and gate CI's Docker publish on it ... - server/test/*.test.ts: formalizes this project's many ad-hoc scratchpad test scripts into a committed suite, one file per service (musicQueueService, partyService, socketGateway, catalogService), using Node's built-in node:test + node:assert/strict - zero new dependencies. Runs straight against TypeScript source via `tsx --test` (npm test), no compile step. - server/tsconfig.test.json: extends the base config, overrides rootDir to "." and adds test/**/*.ts to include, so `npm run typecheck` covers the test files too without pulling them into dist/ (npm run build still uses the unmodified base tsconfig, scoped to src/ only). - server/package.json: typecheck now runs against tsconfig.test.json; new test script. - .forgejo/workflows/publish-docker.yml: new `test` job (node:20-alpine container - the publish job's docker:27-cli has no Node) running server typecheck+test and client typecheck+build; publish now depends on it via needs: test. Removed the stale "no test suite yet" comment. - README.md, docs/architecture.md: documented the test suite, how to run it locally, and the new CI job/gating. Verified locally: server typecheck, server test (25/25 passing), server build, client typecheck, and client build all pass individually - the same commands the new CI job runs. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-09-14 09:57:47 +02:00
Nicolas	4a31ee741e	Rewrite server + client in TypeScript, service-oriented server architecture ... Full rewrite, requested directly. Two independent decisions since TypeScript can't compile itself away at runtime - "no build step" and "TypeScript" are mutually exclusive, not a small addition to the existing setup: - Server: plain tsc (no bundling need - Node resolves its own requires). server/dist mirrors server/src 1:1. - Client: esbuild (does need bundling) - picked over a heavier tool (Vite, webpack) since this app's whole client is a couple thousand lines; its built-in CSS-from-JS bundling and a `text` loader for importing an HTML template as a string cover everything needed via a ~30-line hand-written build script (client/build.mjs), not a config file for something built for much bigger apps. Both projects compile independently (no shared-types package - considered and rejected as more structural commitment than this app's size justifies; server/src/types.ts and client/src/types.ts have their own overlapping DTO copies instead). server/'s `npm run dev` uses tsx for a compile-free dev loop; `npm run build` (tsc) is what server/Dockerfile's build stage actually runs. client/'s `npm run watch` is esbuild's own watch mode. Server: one singleton service class per feature, generalizing the PartyManager/MusicQueueService pattern that already existed, rather than route handlers with logic inline: - AuthService (from embyAuth.js), CatalogService (NEW - previously ~15 route handlers' worth of Emby queries/DTO shaping inlined directly in index.js), PartyService (renamed from PartyManager), MusicQueueService (ported as-is, already service-shaped), SocketGateway (from socketHandler.js), EmbyClient (from embyProxy.js - low-level plumbing, not called a "service" since it has no state/feature of its own). - index.ts is now thin wiring only: every route reads the session, calls one service method, returns the result. - Real error-handling pass, not just a port: Express 4 doesn't catch a rejected Promise from an async handler on its own - a new asyncRoute() wrapper + a single error-handling middleware replace what used to be zero handling for a request that outright throws. CatalogService methods throw a CatalogFetchError (own HTTP status - getRawItem now preserves Emby's real 404 instead of a blanket 502) rather than touching res directly. Client: one folder per view (src/views/<name>/<Name>.ts + .html + .css) instead of one .js file with the markup inline as a template literal. A view's static shell moved to its .html (esbuild's text loader); per-item dynamic content (tile grids, episode/track lists) stays as template -literal-returning functions in the .ts, same as before. Genuinely shared CSS (tiles, the presence avatar, the series/album detail-header pattern, track-list rows) lives under src/styles/, imported by whichever views need it; src/styles/base.css holds the global primitives, imported once by app.ts. Deliberately not pushed to zero duplication/renaming shared classes across views for tidiness alone - not worth the risk in a change already this large. Player.ts keeps its pre-existing internal shape (the /party/:id dispatcher + the video renderer in one file, importing renderMusicPlayer from the sibling folder) - that pattern predates this rewrite and only needed types, not restructuring. Two real things the port itself caught, not just carried over: - A type bug: porting SocketGateway's "members" broadcast, reusing PartyService's PublicMember interface would have type-checked fine but was the wrong (larger) shape - the socket broadcast never included isPaused/positionTicks, only the REST response did. Caught by comparing against the original JS line by line, fixed with a dedicated SocketMemberDto type. - A real Express+TypeScript friction point: noUncheckedIndexedAccess (enabled in both tsconfigs - genuinely useful elsewhere, e.g. PartyService.advanceQueue's array indexing) makes every req.params.xxx read a type error, since Express's index-signature typing doesn't know a matched route's required :name segment is always present. Resolved once with a param(req, name) helper rather than 15 routes' worth of scattered assertions. Verified: both projects type-check cleanly in strict mode (tsc --noEmit - not just "esbuild didn't complain", which it wouldn't even with type errors present, since it transpiles without checking). Server: every unit/integration test from the JS version (party lifecycle logging, the music queue's timer/vote/pause behavior incl. real setTimeout auto-advance, the socket integration through SocketGateway+PartyService+ MusicQueueService together, the library-type filter, the playback -override forcing) re-run against the compiled server/dist output - identical results; the compiled server was actually started and confirmed listening cleanly. Client: since esbuild bundles everything into one app.js (no more individually-importable view modules), testing moved to driving the real compiled bundle through its actual boot -> login -> router -> view chain (mocked fetch/Socket.IO/hls.js, real clicks/hash navigation) - arguably more realistic than the old per-module approach. Confirmed this way: login, the sidebar, home's carousels, a video party (presence, host controls, leave), the full music hierarchy, a music party (presence, vote-skip, pause toggle, the inline browse-and-add panel), and the series page - all through client/dist's actual output, no thrown errors anywhere. Not verified: an actual `docker build` of the new multi-stage Dockerfile - this dev environment has no Docker at all. The build stage runs the exact npm run build commands already confirmed working locally, just inside node:20-alpine - the main remaining risk is something environment -specific, not the build commands themselves, but a real build is still the first thing to try after this lands. docs/architecture.md has the full writeup (new "TypeScript and a service-oriented architecture" section, plus a corrected top-level "Components" overview that had gone stale even before this change). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-09-14 09:38:14 +02:00
Nicolas	efaa7f55f0	Add music: Artist/Album/Track browsing + participative listen-party queue ... The last deferred piece from the original spec. Chosen permission model (asked, not assumed): anyone can add a track to the shared queue any time; anyone can pause/resume directly; skipping the current track needs a strict majority vote of currently connected members. No host for playback - a genuinely different shape of shared state than video's "host drives, everyone follows", which is why it's a separate service (server/src/musicQueueService.js, MusicQueueService) rather than more branches in partyManager.js/socketHandler.js's existing video-shaped logic. Server: - musicQueueService.js: owns a music party's queue/current-track/pause/ vote-skip state. Server-authoritative timing (no client is "the host" reporting position) - a wall-clock startedUtc plus the track's known duration is the only state; auto-advance is one setTimeout scheduled for exactly when that runs out, not any client reporting "it ended" (which could race across several players finishing near-simultaneously with no host to arbitrate). attachIo(io, onTrackChanged), called once at startup like PartyManager's own wiring, lets it broadcast "queueUpdated" from inside that timer's callback, which has no socket/request in scope at all. - The timer is the one new leak surface this adds, given how much this project has already had to fix real leaks - destroy(party) clears it, wired into both of partyManager.js's existing destruction paths (leave's last-member case, removeIdleParties' sweep). - Party gained mediaType: 'video'|'music' (inferred server-side from the clicked item's Emby Type - the client never has to know or say which). - Three new catalog endpoints (Artists -> Albums -> Tracks), same reasoning as the existing Shows -> Seasons -> Episodes: a real Emby endpoint per level, not generic recursive /Items guessing. - Audio streams through the *same* /master.m3u8 route as video (Emby's PlaybackInfo negotiation isn't video-specific) - the one difference is the hand-built-fallback path prefix (/Audio/ vs /Videos/), which the client tags via a mediaType=audio query hint rather than costing an extra Emby round trip to detect server-side. - Adding a track is REST (POST /api/parties/:partyId/tracks), not a socket event like voteSkip/musicPlaystate - it needs to work from the player's inline browse-and-add panel regardless of realtime-connection specifics, and MusicQueueService's own broadcast reaches everyone connected either way. Client: - player.js's renderPartyPlayer is now a small dispatcher: fetches the party once, then delegates to renderVideoPlayer or the new renderMusicPlayer (views/musicPlayer.js) based on mediaType. Can't be async despite awaiting that fetch - route()'s contract needs its cleanup function back synchronously (router.js's `typeof cleanup === 'function'` check would silently skip a Promise, reintroducing the exact leak class already fixed once) - solved with a mutable box returned immediately, filled in once the fetch resolves. - musicPlayer.js: not full-viewport/theater-mode like the video player (no image to declutter around, sidebar stays up) - which is what makes its own inline Artist -> Album -> Track browser work for "add tracks while listening" without navigating away and losing player state or threading party context through query params across three route levels. - New views/artist.js, views/album.js (library.js's music branch renders an artist grid instead of the old placeholder). tiles.js's DRILL_DOWN table generalizes the old single seriesHref special-case now that there are three drill-down targets, not two. - party.js: addTrackToQueue (REST) alongside voteSkip/setMusicPaused (socket) on the existing connectParty() connection object. Real bug found while testing, not just the mock's fault: applyMusicState used to update the queue list/vote button *after* the current-track branch, which calls loadTrack() - and loadTrack()'s hls.js setup can throw. Since JS doesn't roll back earlier statements when a later one throws but does abort everything after it, an exception there took the unrelated queue list and vote tally down with it, and on the first render escaped all the way to the dispatcher's catch, which alerts and bounces back to /home - discarding the whole view over what's really just "this one track's audio failed to load". Fixed by reordering (queue/vote/icon updates - which can't fail - before the track-loading branch, mirroring how player.js's onItemChanged already updates title/next-button before calling loadVideo) and wrapping loadTrack's hls.js setup in its own try/catch so a failure there logs and stops instead of propagating. Verified server-side directly against the real shipped modules (not reimplemented mocks): 18 checks against musicQueueService.js alone (auto -start, queueing, vote-skip majority, pause/resume elapsed-time math, a real setTimeout auto-advance, timer cleanup on destroy - instrumented setTimeout/clearTimeout counting, same technique as the earlier client -side leak tests) and 7 more through socketHandler.js + partyManager.js together (no-ops on a video party, a non-host pausing/resuming, a two-vote majority skip, the resulting broadcast really reaching the room). Client-side against the real local server with mocked fetch/Hls/ io: the full browsing chain, party creation, the dispatcher choosing the right player (and still choosing video when mediaType is absent - back -compat), now-playing/vote-tally/queue rendering and updates including a live track change, play/pause and vote-skip emitting the right events, the inline browse-and-add panel POSTing the right payload, and the crash fix re-confirmed fixed via the same broken scenario that first found it. Not verified: the real Emby round trip for any of this (Artists/albums -tracks response shapes, audio PlaybackInfo/TranscodingUrl behavior, actual playback quality) - same limit as everything else in this project tested without live Emby access. docs/architecture.md has the full writeup. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-09-14 01:49:22 +02:00
Nicolas	0c439259ac	Add server-side logging of the party lifecycle ... Requested now that the app is actually running on real infrastructure: visibility from docker logs/journalctl into what's happening (parties created/destroyed, who joined/left, play/pause, pause requests) without needing to reproduce a bug through the UI first. server/src/logger.js: a deliberately tiny partyLog(message) - plain console.log, prefixed [watchparty:party], ISO timestamp - plus a who(userId, userName) formatter shared by every call site. No logging library; this app runs as a single container, not behind a log aggregator, so a consistent grep-able prefix is what actually helps here. Covers the party's business lifecycle end to end, logged at the source so every caller (REST and socket) is covered without repeating the check: - partyManager.js: create, join, leave (also covers a host handoff or the party being destroyed, both fall out of leave), advanceQueue, removeIdleParties. - socketHandler.js: playstate and requestPause, since those two mutate member state directly rather than through a PartyManager method. The one thing that needed real care: the host's player re-sends its CURRENT play/pause state every 3 seconds regardless of whether anything changed (the heartbeat), on top of firing per actual play/pause/seeked event. Logging every "playstate" message as it arrives would mean one log line every 3 seconds per active party, forever. The handler instead compares incoming isPaused against the member's previous value and only logs on an actual flip - so a party generates exactly one line per real pause or resume, never one per heartbeat tick. Verified directly against the real shipped modules, not reimplemented mocks: a scripted create/join/advanceQueue/leave/idle-sweep sequence against the real partyManager.js produced exactly the expected line at every step; a fake io/socket pair driving the real socketHandler.js through start -> 5 unchanged heartbeats -> pause -> 3 unchanged heartbeats -> resume logged exactly 3 playstate lines (not 9) at exactly the right points, and a throttled repeat requestPause produced no second line - all assertions passed, counted programmatically. docs/architecture.md has the full writeup. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-09-14 00:53:55 +02:00
Nicolas	85bcf946b4	Filter sidebar to films/musique/clips vidéos/TV, fix music videos not being playable ... server/src/index.js: GET /api/catalog/libraries now filters Emby's /Views response to VISIBLE_COLLECTION_TYPES (movies/tvshows/music/musicvideos) before returning it. Emby's /Views can return all sorts of things this app has no UI for at all - boxset collections, playlists, live TV, photos, books, a mixed-content folder with no CollectionType - none of which should ever have shown up in the sidebar. Filtering once at the source means every consumer (the sidebar, home.js's per-library carousels, direct navigation to /library/:id) is restricted the same way without repeating the check in each place; a stale link to a now-hidden library's id just falls into library.js's existing "Bibliothèque introuvable" state, since it looks the id up in this same filtered list. Found while making musicvideos a real visible category: its items are Emby's own 'MusicVideo' type (distinct from the generic 'Video'), which WATCH_PARTY_TYPES didn't include - every tile in a music-videos library would have rendered with no "Lancer une watch party" button at all, only "Voir sur Emby". Added it. Also fixed two stale doc/comment references while touching this code: the sidebar hasn't shown per-type icons since the earlier "no emoji" request (plain text links only), and views/home.js's party carousel has used the live lobby Socket.IO subscription instead of a GET /api/parties fetch since that endpoint was removed - both docs/architecture.md and an inline comment still described the old behavior. Verified: a plain filter/map unit test confirms exactly movies/tvshows/music/musicvideos survive against a mock /Views response seeded with one of every excluded type (photos/livetv/boxsets/playlists/ books/homevideos/mixed/no-type-at-all); WATCH_PARTY_TYPES.has('MusicVideo') checked directly; and mounting shell.js + library.js against a mocked already-filtered libraries response renders exactly the 4 expected sidebar links and a working "Lancer une watch party" button on a MusicVideo tile. docs/architecture.md has the full writeup. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-09-14 00:40:07 +02:00
Nicolas	669873e41c	Presence overlay (avatars) + "request pause" in the player ... Two features requested together: a semi-transparent overlay showing who's in the party, and a way for a non-host to ask the host to pause. - server/src/socketHandler.js: new "requestPause" event (anyone, throttled 5s per member server-side via member.lastPauseRequestUtc - the real guard, independent of whatever the client does) broadcasts "pauseRequested" {userId, userName} to the whole party room, not just the host, so everyone sees why playback is about to pause. - client/js/party.js: connectParty() grows an onPauseRequested callback and the returned connection a requestPause() method, same shape as the existing next()/sendPlaystate(). - client/js/views/player.js: renderMembers() now also rebuilds a #presenceOverlay of one circle per member (initials from userName, colorForName() picks a deterministic background from a small palette by hashing the name - same person, same color, no server-side assignment needed). "Which circle is mine" compares userName against the auth singleton embyApi.js already populates, matching how the rest of the client avoids keying UI logic on userId directly. Your own circle, only when you're not host, is clickable and calls requestPause() (client-side cooldown too, purely to avoid a click that would visibly do nothing - the server-side one is what actually matters). Receiving pauseRequested shows a short auto-clearing banner and pulses the matching circle for everyone, including the requester and the host. - client/css/app.css: .presenceOverlay/.avatar (bottom-left, opacity .75 is the "semi transparence" itself) and the clickable/sent/pulse states, .pauseRequestBanner. Verified with mocked members/pauseRequested Socket.IO events against the real running local server (see session history): initials/colors render correctly, the host's own circle never gets the clickable affordance, rapid repeat clicks collapse to exactly one requestPause emission (three synchronous clicks -> one new emitted event), a pauseRequested event banners and pulses the right circle. Re-checked the pre-existing host path (becomeHost, settings menu, next-episode button) still works unchanged - this pass only touched renderMembers() and init()'s connectParty() call. docs/architecture.md has the full writeup. Also fixed two roadmap checkboxes in README.md that should have been checked off by the previous commit (live lobby/host handoff/no join codes) but were missed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-09-14 00:05:40 +02:00
Nicolas	b6019bd211	Live lobby, host handoff reflected live, remove join codes, fix player scroll ... Three requested changes plus one found-in-passing bug fix: 1. Home page's "watch parties en cours" is now a live Socket.IO subscription (connectLobby -> "lobby" room), not a one-shot fetch - updates the instant anything changes anywhere (create/join/leave). Host name + member count come from the snapshot; elapsed time ticks purely client-side from a createdUtc timestamp (no point pushing a recomputed duration every second for every viewer). home.js returns this subscription from its router cleanup, same leak-prevention pattern as the player's socket. 2. Host handoff is now live end to end, not just correct in the data model. PartyManager.leave already promoted another member and destroyed an empty party (that part predates this change) - what was missing was any way for an already-open follower player to find out it became host. applyLeave (shared by the socket leave/ disconnect handlers and the REST leave endpoint, so this and the lobby broadcast only live in one place) now emits a personal "hostChanged" to the new host's own socket; player.js's becomeHost() unlocks controls live. becomeHost is written to tolerate being called more than once safely (addEventListener no-ops on a repeat identical listener; the heartbeat setInterval is explicitly guarded since it has no such idempotence - calling it twice would leak the first interval, the exact bug class the previous pass fixed). 3. No more join codes - PartyManager no longer generates or tracks one. The live lobby list is the only discovery mechanism now; a code copied out of band doesn't add anything on top of a list that's already always current. POST /api/parties/:partyId/join replaces :joinCode; the "Rejoindre avec un code" UI is gone. Found while touching this: the home page's "Rejoindre" button used to navigate to the player WITHOUT ever calling the join endpoint first - it loaded fine (GET /api/parties/:id never checked membership) but the realtime "join" was silently rejected server-side (not an actual member), so sync never worked for anyone joining this way. Fixed to await joinParty() before navigating, matching how the library grid's tiles already did it. Also: .playerWrap was width:100%/height:100vh inside .mainContent's own padding, so the two stacked and made the page taller than the viewport - an outer scrollbar despite the video already being full- height. Changed to position:fixed/inset:0 so it fills the real viewport regardless of ancestor padding. Verified live against a real running server (see session history): lobby subscription renders host/member-count/ticking-elapsed correctly from a faked "parties" push (createdUtc 2:05 in the past rendered "2:06" after ~1s more, proving the client-side tick is real, not static); the join-then-navigate fix calls the join endpoint before navigating; .playerWrap computes to position:fixed with all four insets at 0. docs/architecture.md has the full writeup. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-09-13 23:47:12 +02:00
Nicolas	5d535d18d8	Switch to Socket.IO; fix two real memory leaks ... Requested: Socket.IO instead of raw WebSockets, and explicit attention to memory leaks. Auditing for the second turned up two real, concrete leaks, independent of the transport library: 1. Server-side: a raw `ws` server has no idea a client is gone unless it gets a proper close frame - a sleeping laptop, a network drop, a killed tab never fire 'close', so the PartyMember's socket reference (and everything it closes over) sat in memory forever, and the party was never cleaned up by anything else either (removeIdleParties only looks at lastActivityUtc). Socket.IO's built-in heartbeat (pingInterval/pingTimeout) detects and closes these out on its own - a real, not just cosmetic, reason to prefer it here. 2. Client-side: router.js only ever did currentRoot.innerHTML = '' between routes, destroying DOM but never telling the outgoing view's JS to stop. Leaving the player any way other than its own "Quitter" button (a sidebar link, browser back) left the 3s heartbeat setInterval, the realtime connection, and the hls.js instance all running against a detached <video> indefinitely, for as long as the tab stayed open. Fixes: - server/src/socketHandler.js replaces wsHandler.js: same protocol (see its own top comment), over Socket.IO. Rooms (socket.join/ io.to) replace manually iterating party.members to broadcast. Error event renamed to "errorMessage" - Socket.IO reserves "error". - server/src/index.js: socket.io server instead of a raw WebSocketServer, same-origin (no CORS config needed). - client/js/party.js: socket.io-client (window.io, loaded via <script> in index.html) instead of hand-rolled WebSocket + JSON framing - also gets automatic reconnection for free. - router.js: route() handlers may now return a cleanup function; render() calls whatever the previous view returned before switching to the next route, regardless of how navigation happened. - player.js returns a cleanup that clears the heartbeat, destroys hls, disconnects the socket, and removes its document-level click listener (now named, not inline-anonymous, specifically so it CAN be removed - an anonymous one added fresh per visit would itself have been a slow leak even with everything else fixed). The "Quitter" button is now just navigate('/home') - cleanup runs the same way regardless of how you leave. Verified for real (see session history): a real Socket.IO client connected to a really-running local server end to end. Then, with document.addEventListener/removeEventListener and setInterval/ clearInterval instrumented, drove the router through repeated "join a party, then navigate away without clicking Quitter" cycles - adds and removes matched exactly every time (3/3 listeners over three cycles, 2/2 intervals over two), nothing left pending. docs/architecture.md has the full writeup under "Realtime transport: Socket.IO, and two real memory leaks". Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-09-13 23:07:51 +02:00
Nicolas	f563f5b0a2	Emby-style UI: sidebar, carousels, series drill-down, episode queue, player tracks ... Big UI pass towards looking/behaving like Emby. Deferred: music (needs its own player + a real-time collaborative playlist - different enough subsystem to be its own pass; sidebar/routing already treat it as a first-class collectionType, page just says "not yet" for now). Layout: - client/js/shell.js: persistent sidebar (one entry per Emby library, from GET /api/catalog/libraries which now also returns collectionType) + a #mainContent the router swaps on navigation. router.js made idempotent (start() safe to call more than once) so a login -> shell boot can happen twice in one page lifetime (logout then back in) without piling up duplicate hashchange listeners. - app.js's boot() renders either the bare login screen or the full shell depending on session state; login.js calls it again on success instead of navigate() (no router running yet at that point). Browsing, by collection type: - views/home.js (route /home): a carousel of every active party server-wide, a join-by-code fallback, then one "recently added" carousel per non-music library (GET /api/catalog/libraries/:id/recent, Emby's Items/Latest). - views/library.js (route /library/:id): dispatches on collectionType - movies/tvshows get the tile grid (Series tiles link into /series/:id instead of starting a party directly), music gets an honest placeholder. - views/series.js (route /series/:id): season tabs + episode list (new GET /api/catalog/series/:id/seasons and .../episodes, Emby's /Shows/{id}/Seasons and /Episodes). - tiles.js: poster-tile rendering shared by home.js and library.js so they can't drift apart. Episode queue / "next episode": - POST /api/parties now builds a queue when starting from an episode (fetches the rest of the series, from that episode onward) - partyManager.js gained queue/queueIndex/advanceQueue. - New WS message {type:"next"} (host-only) advances the queue and broadcasts {type:"itemChanged", itemId, itemName, ...}; every client reloads the player against the new item. player.js shows "Épisode suivant" when hasNext, and auto-sends next() on the video's `ended` event. Player: language/subtitles/quality: - New GET /api/catalog/item/:id/playback-options exposes PlaybackInfo's MediaStreams as audio/subtitle track lists. - master.m3u8 now forwards AudioStreamIndex/SubtitleStreamIndex/ MaxStreamingBitrate to PlaybackInfo; player.js has three <select>s (host-only) that reload the stream at the same position on change. Subtitles end up burned into the transcode (via SubtitleStreamIndex), not a toggleable track - simpler than sidecar WebVTT for this pass. "Quality" is a MaxStreamingBitrate ceiling, not true adaptive bitrate. Verified by driving a browser against mocked /api/* responses (see session history): sidebar renders/highlights correctly, home carousels render (parties + one row per non-music library, music correctly skipped), library grid dispatch works, series page season-tab switching + episode list render and the season/episode navigation flow works end to end. Real Emby response shapes for all of this (Views' CollectionType, Seasons/Episodes, Items/Latest, PlaybackInfo's MediaStreams) and the queue/track-picker protocol are NOT yet confirmed against a live server - see docs/architecture.md. Removed client/js/views/browse.js, superseded by home.js + library.js. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-09-13 22:44:49 +02:00
Nicolas	b6818655b1	Proxy all Emby access through our own backend; drop server-url field; use Emby's real theme colors ... Three changes requested: 1. Server proxies Emby, browser never talks to it directly. Login is now POST /api/auth/login {username,password} on our own backend; the backend calls Emby's AuthenticateByName server-side and mints its own opaque session (httpOnly cookie), storing {embyToken,userId,userName} in memory. The browser never sees or holds a real Emby access token. Every other call - search, item details, images, HLS streaming, party actions - goes to our own /api/* origin, authenticated by that cookie; server/src/embyProxy.js forwards to Emby server-side and streams the response back (including a playlist-rewrite pass for HLS .m3u8 so hls.js never gets handed a URL pointing at Emby directly). This also sidesteps the CORS problem the previous direct-to-Emby design had. 2. EMBY_SERVER_URL is backend-only config (.env.example); the login form no longer asks for a server address at all. 3. client/css/app.css now uses colors read directly off the live Emby server's own dark theme (--theme-primary-color-* etc, fetched via a JS probe against the running client, not guessed): accent green #52b54b/#6ccf65, near-black background #151216. Tested for real: ran the server locally against the actual EMBY_SERVER_URL and submitted intentionally-wrong credentials through the UI - confirmed the full round trip (browser -> our backend -> real Emby -> real 401 -> our error message) with no CORS issue, since it's all server-to-server now. Login itself hasn't been exercised with real credentials, so catalog/streaming remain unverified - see docs/architecture.md. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-09-13 21:36:26 +02:00
Nicolas	6ff9aa29e2	Pivot to a standalone app - Emby plugin hit a hard wall ... No plugin API exists for adding a button to Emby's player or item detail page (confirmed by an Emby developer on their own forum, and by research since). The only way to reach that would be patching Emby's shipped web client files directly - outside the plugin, breaks on every image update, needs manual reapplication. Not worth the ongoing cost, per discussion. New direction: a standalone app with its own player. Reads Emby's catalog/streams directly from the browser (no plugin, no menu integration fights); a small Node backend only coordinates party membership and relays playback state over WebSocket - it never touches a media byte. Auth is Emby-only, as chosen: the browser signs in against Emby directly and this backend validates whatever token it gets handed by asking Emby itself (GET /Users/{userId}), never seeing a password. Control model changed too: now that we own the player, host controls playback and everyone else follows (event-driven play/pause/seek + a 3s heartbeat, drift-corrected on the follower side) - the old plugin's "everyone keeps their own controls, shared reference position" was specifically a concession to nudging pre-existing Emby app sessions we didn't control, which no longer applies. - server/: Express + ws backend (party lifecycle, WebSocket protocol, Emby token validation) - client/: plain-JS/ES-modules frontend (login, search, item detail, party player) - no build step - Smoke-tested locally end to end against a stubbed Emby URL: server starts, routing/auth-gating works, error handling degrades gracefully (network failure, invalid token) - see the session transcript for the actual browser test run - docs/architecture.md rewritten around the new design, including why the plugin was abandoned and a fresh "assumptions to verify" list (CORS between this app's origin and Emby's is the biggest unknown) - src/WatchParty/ (the Emby plugin) kept as-is for reference, no longer the active direction Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-09-13 20:48:55 +02:00
Nicolas	6f22f72532	Integrate Watch Party into Emby's own UI instead of a standalone app ... Per user feedback: no separate control panel, no chat. Found that PluginPageInfo has EnableInUserMenu/EnableInMainMenu (confirmed via reflection on the real MediaBrowser.Model assembly, plus an Emby community thread showing another plugin using EnableInUserMenu=true) - a real, if barely documented, way to surface a plugin page to regular users, not just admins, through the exact same IHasWebPages/GetPages() mechanism as the admin settings page. - Plugin.cs now registers a second page (partyPage.html) with EnableInUserMenu=true + EnableInMainMenu=true - partyPage.html replaces the old standalone control panel: no login form, it runs inside the already-authenticated Emby web client and calls the REST API via the global ApiClient - Removed web/control-panel/ (the standalone app, its own login flow, and the custom GET /WatchParty/app* static file routes in WatchPartyService.cs) - no longer needed - docs/architecture.md and README.md updated: the new mechanism, and the honest limitation that comes with it (reaches Web/Electron clients, not official mobile/TV apps - those allowlist plugin pages client-side) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-09-13 19:44:31 +02:00
Nicolas	db815df7d5	Fix plugin to build clean against real Emby 4.9.1.90 SDK ... Installed .NET 8 SDK (per-user, winget needed admin elevation this machine doesn't have) and restored the real MediaBrowser.Server.Core / MediaBrowser.Common packages, then fixed everything the compiler and a bit of reflection surfaced: - PlaybackProgressEventArgs/PlaybackStopEventArgs are in MediaBrowser.Controller.Library, not ...Session - IAuthorizationContext/AuthorizationInfo are in MediaBrowser.Controller.Net - Item/user/session ids (SessionInfo.Id/UserId, BaseItemDto.Id) are plain string on this SDK version, not Guid - Party/PartyMember updated accordingly (Party.Id stays a Guid; it's minted by this plugin, not Emby) - Reading the calling user needed an extra step: IAuthorizationContext.GetAuthorizationInfo(Request).UserId is a `long` (internal row id); .User.Id is the one matching SessionInfo.UserId, but it's a Guid so it's reformatted with .ToString("N") docs/architecture.md's "Assumptions to verify" now reflects what was actually confirmed vs. what's still only compile-checked (HTTP status codes, content-type headers, the JS auth header format, the dashboard config page) pending a run against a real server. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-09-13 14:40:17 +02:00
Nicolas	66af05f259	Scaffold Emby Watch Party plugin ... Design: coordinate parties on top of Emby's existing session remote-control commands (SendPlaystateCommand) rather than building a new player. Each member keeps their own Emby app/controls; the server periodically corrects drift and mirrors pause/unpause against one reference member's reported position. - src/WatchParty: plugin skeleton (BasePlugin, IServerEntryPoint, IService/[Route] API, in-memory party store, drift-correction loop) - web/control-panel: plain HTML/JS/CSS companion page to create/join parties and resync, served by the plugin itself - docs/architecture.md: full design, sources consulted, and an explicit list of SDK details that still need verifying against a real build (no .NET SDK / Emby SDK assemblies available in this environment to compile against) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-09-13 14:02:43 +02:00