62 commits

Author	SHA1	Message	Date
Nicolas	4a31ee741e	Rewrite server + client in TypeScript, service-oriented server architecture ... Full rewrite, requested directly. Two independent decisions since TypeScript can't compile itself away at runtime - "no build step" and "TypeScript" are mutually exclusive, not a small addition to the existing setup: - Server: plain tsc (no bundling need - Node resolves its own requires). server/dist mirrors server/src 1:1. - Client: esbuild (does need bundling) - picked over a heavier tool (Vite, webpack) since this app's whole client is a couple thousand lines; its built-in CSS-from-JS bundling and a `text` loader for importing an HTML template as a string cover everything needed via a ~30-line hand-written build script (client/build.mjs), not a config file for something built for much bigger apps. Both projects compile independently (no shared-types package - considered and rejected as more structural commitment than this app's size justifies; server/src/types.ts and client/src/types.ts have their own overlapping DTO copies instead). server/'s `npm run dev` uses tsx for a compile-free dev loop; `npm run build` (tsc) is what server/Dockerfile's build stage actually runs. client/'s `npm run watch` is esbuild's own watch mode. Server: one singleton service class per feature, generalizing the PartyManager/MusicQueueService pattern that already existed, rather than route handlers with logic inline: - AuthService (from embyAuth.js), CatalogService (NEW - previously ~15 route handlers' worth of Emby queries/DTO shaping inlined directly in index.js), PartyService (renamed from PartyManager), MusicQueueService (ported as-is, already service-shaped), SocketGateway (from socketHandler.js), EmbyClient (from embyProxy.js - low-level plumbing, not called a "service" since it has no state/feature of its own). - index.ts is now thin wiring only: every route reads the session, calls one service method, returns the result. - Real error-handling pass, not just a port: Express 4 doesn't catch a rejected Promise from an async handler on its own - a new asyncRoute() wrapper + a single error-handling middleware replace what used to be zero handling for a request that outright throws. CatalogService methods throw a CatalogFetchError (own HTTP status - getRawItem now preserves Emby's real 404 instead of a blanket 502) rather than touching res directly. Client: one folder per view (src/views/<name>/<Name>.ts + .html + .css) instead of one .js file with the markup inline as a template literal. A view's static shell moved to its .html (esbuild's text loader); per-item dynamic content (tile grids, episode/track lists) stays as template -literal-returning functions in the .ts, same as before. Genuinely shared CSS (tiles, the presence avatar, the series/album detail-header pattern, track-list rows) lives under src/styles/, imported by whichever views need it; src/styles/base.css holds the global primitives, imported once by app.ts. Deliberately not pushed to zero duplication/renaming shared classes across views for tidiness alone - not worth the risk in a change already this large. Player.ts keeps its pre-existing internal shape (the /party/:id dispatcher + the video renderer in one file, importing renderMusicPlayer from the sibling folder) - that pattern predates this rewrite and only needed types, not restructuring. Two real things the port itself caught, not just carried over: - A type bug: porting SocketGateway's "members" broadcast, reusing PartyService's PublicMember interface would have type-checked fine but was the wrong (larger) shape - the socket broadcast never included isPaused/positionTicks, only the REST response did. Caught by comparing against the original JS line by line, fixed with a dedicated SocketMemberDto type. - A real Express+TypeScript friction point: noUncheckedIndexedAccess (enabled in both tsconfigs - genuinely useful elsewhere, e.g. PartyService.advanceQueue's array indexing) makes every req.params.xxx read a type error, since Express's index-signature typing doesn't know a matched route's required :name segment is always present. Resolved once with a param(req, name) helper rather than 15 routes' worth of scattered assertions. Verified: both projects type-check cleanly in strict mode (tsc --noEmit - not just "esbuild didn't complain", which it wouldn't even with type errors present, since it transpiles without checking). Server: every unit/integration test from the JS version (party lifecycle logging, the music queue's timer/vote/pause behavior incl. real setTimeout auto-advance, the socket integration through SocketGateway+PartyService+ MusicQueueService together, the library-type filter, the playback -override forcing) re-run against the compiled server/dist output - identical results; the compiled server was actually started and confirmed listening cleanly. Client: since esbuild bundles everything into one app.js (no more individually-importable view modules), testing moved to driving the real compiled bundle through its actual boot -> login -> router -> view chain (mocked fetch/Socket.IO/hls.js, real clicks/hash navigation) - arguably more realistic than the old per-module approach. Confirmed this way: login, the sidebar, home's carousels, a video party (presence, host controls, leave), the full music hierarchy, a music party (presence, vote-skip, pause toggle, the inline browse-and-add panel), and the series page - all through client/dist's actual output, no thrown errors anywhere. Not verified: an actual `docker build` of the new multi-stage Dockerfile - this dev environment has no Docker at all. The build stage runs the exact npm run build commands already confirmed working locally, just inside node:20-alpine - the main remaining risk is something environment -specific, not the build commands themselves, but a real build is still the first thing to try after this lands. docs/architecture.md has the full writeup (new "TypeScript and a service-oriented architecture" section, plus a corrected top-level "Components" overview that had gone stale even before this change). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-09-14 09:38:14 +02:00
Nicolas	efaa7f55f0	Add music: Artist/Album/Track browsing + participative listen-party queue ... The last deferred piece from the original spec. Chosen permission model (asked, not assumed): anyone can add a track to the shared queue any time; anyone can pause/resume directly; skipping the current track needs a strict majority vote of currently connected members. No host for playback - a genuinely different shape of shared state than video's "host drives, everyone follows", which is why it's a separate service (server/src/musicQueueService.js, MusicQueueService) rather than more branches in partyManager.js/socketHandler.js's existing video-shaped logic. Server: - musicQueueService.js: owns a music party's queue/current-track/pause/ vote-skip state. Server-authoritative timing (no client is "the host" reporting position) - a wall-clock startedUtc plus the track's known duration is the only state; auto-advance is one setTimeout scheduled for exactly when that runs out, not any client reporting "it ended" (which could race across several players finishing near-simultaneously with no host to arbitrate). attachIo(io, onTrackChanged), called once at startup like PartyManager's own wiring, lets it broadcast "queueUpdated" from inside that timer's callback, which has no socket/request in scope at all. - The timer is the one new leak surface this adds, given how much this project has already had to fix real leaks - destroy(party) clears it, wired into both of partyManager.js's existing destruction paths (leave's last-member case, removeIdleParties' sweep). - Party gained mediaType: 'video'|'music' (inferred server-side from the clicked item's Emby Type - the client never has to know or say which). - Three new catalog endpoints (Artists -> Albums -> Tracks), same reasoning as the existing Shows -> Seasons -> Episodes: a real Emby endpoint per level, not generic recursive /Items guessing. - Audio streams through the *same* /master.m3u8 route as video (Emby's PlaybackInfo negotiation isn't video-specific) - the one difference is the hand-built-fallback path prefix (/Audio/ vs /Videos/), which the client tags via a mediaType=audio query hint rather than costing an extra Emby round trip to detect server-side. - Adding a track is REST (POST /api/parties/:partyId/tracks), not a socket event like voteSkip/musicPlaystate - it needs to work from the player's inline browse-and-add panel regardless of realtime-connection specifics, and MusicQueueService's own broadcast reaches everyone connected either way. Client: - player.js's renderPartyPlayer is now a small dispatcher: fetches the party once, then delegates to renderVideoPlayer or the new renderMusicPlayer (views/musicPlayer.js) based on mediaType. Can't be async despite awaiting that fetch - route()'s contract needs its cleanup function back synchronously (router.js's `typeof cleanup === 'function'` check would silently skip a Promise, reintroducing the exact leak class already fixed once) - solved with a mutable box returned immediately, filled in once the fetch resolves. - musicPlayer.js: not full-viewport/theater-mode like the video player (no image to declutter around, sidebar stays up) - which is what makes its own inline Artist -> Album -> Track browser work for "add tracks while listening" without navigating away and losing player state or threading party context through query params across three route levels. - New views/artist.js, views/album.js (library.js's music branch renders an artist grid instead of the old placeholder). tiles.js's DRILL_DOWN table generalizes the old single seriesHref special-case now that there are three drill-down targets, not two. - party.js: addTrackToQueue (REST) alongside voteSkip/setMusicPaused (socket) on the existing connectParty() connection object. Real bug found while testing, not just the mock's fault: applyMusicState used to update the queue list/vote button *after* the current-track branch, which calls loadTrack() - and loadTrack()'s hls.js setup can throw. Since JS doesn't roll back earlier statements when a later one throws but does abort everything after it, an exception there took the unrelated queue list and vote tally down with it, and on the first render escaped all the way to the dispatcher's catch, which alerts and bounces back to /home - discarding the whole view over what's really just "this one track's audio failed to load". Fixed by reordering (queue/vote/icon updates - which can't fail - before the track-loading branch, mirroring how player.js's onItemChanged already updates title/next-button before calling loadVideo) and wrapping loadTrack's hls.js setup in its own try/catch so a failure there logs and stops instead of propagating. Verified server-side directly against the real shipped modules (not reimplemented mocks): 18 checks against musicQueueService.js alone (auto -start, queueing, vote-skip majority, pause/resume elapsed-time math, a real setTimeout auto-advance, timer cleanup on destroy - instrumented setTimeout/clearTimeout counting, same technique as the earlier client -side leak tests) and 7 more through socketHandler.js + partyManager.js together (no-ops on a video party, a non-host pausing/resuming, a two-vote majority skip, the resulting broadcast really reaching the room). Client-side against the real local server with mocked fetch/Hls/ io: the full browsing chain, party creation, the dispatcher choosing the right player (and still choosing video when mediaType is absent - back -compat), now-playing/vote-tally/queue rendering and updates including a live track change, play/pause and vote-skip emitting the right events, the inline browse-and-add panel POSTing the right payload, and the crash fix re-confirmed fixed via the same broken scenario that first found it. Not verified: the real Emby round trip for any of this (Artists/albums -tracks response shapes, audio PlaybackInfo/TranscodingUrl behavior, actual playback quality) - same limit as everything else in this project tested without live Emby access. docs/architecture.md has the full writeup. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-09-14 01:49:22 +02:00
Nicolas	0f3c364b42	Fix "Voir les épisodes" rendering as a bare link instead of a button ... Bug report: the button wasn't as visible as the others on a tile. Cause: the global `button {}` rule in app.css that gives "Lancer une watch party" its solid green look is tag-scoped, so it never applied to "Voir les épisodes" - the one .tileBtn that's an <a> (a plain hash link, not a <button>). "Voir sur Emby" avoided the same fate only because it also carries .tileBtnLink, which explicitly sets its own background/color. "Voir les épisodes" had neither, so it rendered as a bare, small, default-blue link sitting on the tile overlay next to two solid buttons. Fixed by moving the solid-button look onto .tileBtn itself (tag-agnostic: background/color/border-radius/font-weight/hover), with .tileBtnLink now overriding just the two properties that make "Voir sur Emby" read as the secondary action. This is the semantically right fix, not just a visual patch: for a Series tile "Voir les épisodes" IS the primary action (a Series is never itself directly playable - WATCH_PARTY_TYPES in server/src/index.js - so the two buttons never compete on the same tile) - it should look like one, matching "Lancer une watch party"'s weight exactly rather than "Voir sur Emby"'s secondary one. Verified via computed styles on a mocked library grid (one Movie tile, one Series tile): "Lancer une watch party" and "Voir les épisodes" now compute to the identical rgb(82, 181, 75) background / white text / 600 weight / 8px radius, while "Voir sur Emby" on both tiles still computes to the distinct secondary rgb(38, 38, 38). docs/architecture.md has the full writeup. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-09-14 00:48:04 +02:00
Nicolas	f6a8010647	Move presence overlay to the top, orange badge for pause requests, series detail page ... Two rounds of feedback on the previous commit, plus a related feature request: 1. Presence overlay moved from bottom-left to the top of the player. client/js/views/player.js: the top gradient bar is now .topOverlay, a column of two stacked rows - .actionBar (what used to be the whole bar: title/members-text/next/settings/leave) and #presenceOverlay directly below it. Stacking them in normal flow means the avatar row always lands right after the action bar regardless of how tall that bar renders (it wraps on narrow screens), instead of a second absolutely-positioned block at a guessed pixel offset. 2. "Someone requested a pause" is now a specific orange border (.avatarPauseRequested, #ff9800) plus a small pause-icon badge in the circle's corner (.avatarPauseBadge - a plain inline two-bar SVG, not a Unicode glyph, since pause/play characters default to emoji presentation on several platforms and look muddy at 10px) - replacing the previous generic box-shadow pulse. This also absorbed the separate "click feedback" ring that used to live only on the requester's own circle (.avatarSent): since the server already broadcasts "pauseRequested" back to the requester too, one state driven purely by that broadcast is simpler than two overlapping ones. Found while repositioning the banner above .followerNotice: the notice is a <p>, and for an absolutely positioned element "bottom" places the MARGIN edge, so its default ~1em user-agent margin was quietly rendering it 13px higher than its declared bottom:24px ever suggested. Gave it margin:0. 3. Series detail page (client/js/views/series.js): the page now opens with an actual detail header - poster, title + year, overview, "Voir sur Emby" - above the season tabs/episode list, instead of a bare <h1>. The season/episode browsing and per-episode "Lancer une watch party" already worked end to end (library grid -> Series tile -> this route); this pass only made the page look like a detail page. Reused toItemDto's existing fields (GET /api/catalog/item/:id), no backend changes needed. Widened .linklike's CSS selector from `button.linklike` to `.linklike` so the new "Voir sur Emby" <a> picks it up too - app.css has no global `a` reset, so an unclassed anchor would otherwise render with the browser's default blue/underline. Verified with mocked Socket.IO events / API responses against the real running local server (see session history): presence row renders directly under the action bar; a pauseRequested event gives the right circle rgb(255, 152, 0) as its computed border color and display:flex on its badge while leaving every other circle untouched (checked via computed styles, not just class names); rapid repeat clicks on your own circle still collapse to exactly one requestPause emission; banner/followerNotice gap measured 15px after the margin fix, versus 2px before it; the series page's header renders correctly, season-tab switching swaps the episode list, a tvshows library's Series tiles link to /series/:id via both the poster and "Voir les épisodes", and starting an episode's party correctly creates it and navigates to the player. docs/architecture.md has the full writeup. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-09-14 00:22:07 +02:00
Nicolas	669873e41c	Presence overlay (avatars) + "request pause" in the player ... Two features requested together: a semi-transparent overlay showing who's in the party, and a way for a non-host to ask the host to pause. - server/src/socketHandler.js: new "requestPause" event (anyone, throttled 5s per member server-side via member.lastPauseRequestUtc - the real guard, independent of whatever the client does) broadcasts "pauseRequested" {userId, userName} to the whole party room, not just the host, so everyone sees why playback is about to pause. - client/js/party.js: connectParty() grows an onPauseRequested callback and the returned connection a requestPause() method, same shape as the existing next()/sendPlaystate(). - client/js/views/player.js: renderMembers() now also rebuilds a #presenceOverlay of one circle per member (initials from userName, colorForName() picks a deterministic background from a small palette by hashing the name - same person, same color, no server-side assignment needed). "Which circle is mine" compares userName against the auth singleton embyApi.js already populates, matching how the rest of the client avoids keying UI logic on userId directly. Your own circle, only when you're not host, is clickable and calls requestPause() (client-side cooldown too, purely to avoid a click that would visibly do nothing - the server-side one is what actually matters). Receiving pauseRequested shows a short auto-clearing banner and pulses the matching circle for everyone, including the requester and the host. - client/css/app.css: .presenceOverlay/.avatar (bottom-left, opacity .75 is the "semi transparence" itself) and the clickable/sent/pulse states, .pauseRequestBanner. Verified with mocked members/pauseRequested Socket.IO events against the real running local server (see session history): initials/colors render correctly, the host's own circle never gets the clickable affordance, rapid repeat clicks collapse to exactly one requestPause emission (three synchronous clicks -> one new emitted event), a pauseRequested event banners and pulses the right circle. Re-checked the pre-existing host path (becomeHost, settings menu, next-episode button) still works unchanged - this pass only touched renderMembers() and init()'s connectParty() call. docs/architecture.md has the full writeup. Also fixed two roadmap checkboxes in README.md that should have been checked off by the previous commit (live lobby/host handoff/no join codes) but were missed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-09-14 00:05:40 +02:00
Nicolas	b6019bd211	Live lobby, host handoff reflected live, remove join codes, fix player scroll ... Three requested changes plus one found-in-passing bug fix: 1. Home page's "watch parties en cours" is now a live Socket.IO subscription (connectLobby -> "lobby" room), not a one-shot fetch - updates the instant anything changes anywhere (create/join/leave). Host name + member count come from the snapshot; elapsed time ticks purely client-side from a createdUtc timestamp (no point pushing a recomputed duration every second for every viewer). home.js returns this subscription from its router cleanup, same leak-prevention pattern as the player's socket. 2. Host handoff is now live end to end, not just correct in the data model. PartyManager.leave already promoted another member and destroyed an empty party (that part predates this change) - what was missing was any way for an already-open follower player to find out it became host. applyLeave (shared by the socket leave/ disconnect handlers and the REST leave endpoint, so this and the lobby broadcast only live in one place) now emits a personal "hostChanged" to the new host's own socket; player.js's becomeHost() unlocks controls live. becomeHost is written to tolerate being called more than once safely (addEventListener no-ops on a repeat identical listener; the heartbeat setInterval is explicitly guarded since it has no such idempotence - calling it twice would leak the first interval, the exact bug class the previous pass fixed). 3. No more join codes - PartyManager no longer generates or tracks one. The live lobby list is the only discovery mechanism now; a code copied out of band doesn't add anything on top of a list that's already always current. POST /api/parties/:partyId/join replaces :joinCode; the "Rejoindre avec un code" UI is gone. Found while touching this: the home page's "Rejoindre" button used to navigate to the player WITHOUT ever calling the join endpoint first - it loaded fine (GET /api/parties/:id never checked membership) but the realtime "join" was silently rejected server-side (not an actual member), so sync never worked for anyone joining this way. Fixed to await joinParty() before navigating, matching how the library grid's tiles already did it. Also: .playerWrap was width:100%/height:100vh inside .mainContent's own padding, so the two stacked and made the page taller than the viewport - an outer scrollbar despite the video already being full- height. Changed to position:fixed/inset:0 so it fills the real viewport regardless of ancestor padding. Verified live against a real running server (see session history): lobby subscription renders host/member-count/ticking-elapsed correctly from a faked "parties" push (createdUtc 2:05 in the past rendered "2:06" after ~1s more, proving the client-side tick is real, not static); the join-then-navigate fix calls the join endpoint before navigating; .playerWrap computes to position:fixed with all four insets at 0. docs/architecture.md has the full writeup. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-09-13 23:47:12 +02:00
Nicolas	5d535d18d8	Switch to Socket.IO; fix two real memory leaks ... Requested: Socket.IO instead of raw WebSockets, and explicit attention to memory leaks. Auditing for the second turned up two real, concrete leaks, independent of the transport library: 1. Server-side: a raw `ws` server has no idea a client is gone unless it gets a proper close frame - a sleeping laptop, a network drop, a killed tab never fire 'close', so the PartyMember's socket reference (and everything it closes over) sat in memory forever, and the party was never cleaned up by anything else either (removeIdleParties only looks at lastActivityUtc). Socket.IO's built-in heartbeat (pingInterval/pingTimeout) detects and closes these out on its own - a real, not just cosmetic, reason to prefer it here. 2. Client-side: router.js only ever did currentRoot.innerHTML = '' between routes, destroying DOM but never telling the outgoing view's JS to stop. Leaving the player any way other than its own "Quitter" button (a sidebar link, browser back) left the 3s heartbeat setInterval, the realtime connection, and the hls.js instance all running against a detached <video> indefinitely, for as long as the tab stayed open. Fixes: - server/src/socketHandler.js replaces wsHandler.js: same protocol (see its own top comment), over Socket.IO. Rooms (socket.join/ io.to) replace manually iterating party.members to broadcast. Error event renamed to "errorMessage" - Socket.IO reserves "error". - server/src/index.js: socket.io server instead of a raw WebSocketServer, same-origin (no CORS config needed). - client/js/party.js: socket.io-client (window.io, loaded via <script> in index.html) instead of hand-rolled WebSocket + JSON framing - also gets automatic reconnection for free. - router.js: route() handlers may now return a cleanup function; render() calls whatever the previous view returned before switching to the next route, regardless of how navigation happened. - player.js returns a cleanup that clears the heartbeat, destroys hls, disconnects the socket, and removes its document-level click listener (now named, not inline-anonymous, specifically so it CAN be removed - an anonymous one added fresh per visit would itself have been a slow leak even with everything else fixed). The "Quitter" button is now just navigate('/home') - cleanup runs the same way regardless of how you leave. Verified for real (see session history): a real Socket.IO client connected to a really-running local server end to end. Then, with document.addEventListener/removeEventListener and setInterval/ clearInterval instrumented, drove the router through repeated "join a party, then navigate away without clicking Quitter" cycles - adds and removes matched exactly every time (3/3 listeners over three cycles, 2/2 intervals over two), nothing left pending. docs/architecture.md has the full writeup under "Realtime transport: Socket.IO, and two real memory leaks". Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-09-13 23:07:51 +02:00
Nicolas	02587632ff	Fix tile sizing, move player options into a gear menu, surface player errors ... 1. Carousel/grid tiles had inconsistent widths - classic flexbox/grid "min-width: auto" pitfall: a long title (or an image's intrinsic size before load) could force a tile wider than its declared flex-basis/track size. Fixed with min-width: 0 on .tile. Verified: three tiles (one with a deliberately very long title) now measure exactly 160px each. 2. Player language/subtitle/quality controls were three always-visible dropdowns floating over the video. Moved behind a small gear-icon button in the action bar that opens a compact popup panel (closes on outside click or on selecting an option) - host-only, same as before. 3. Sidebar library entries no longer get an emoji prefix - plain names. 4. Player failures were silent (a caught error with just a code comment, or hls.js failing with nothing shown). Added: a loading notice while the stream loads, an on-screen error box (with a Réessayer button) for fatal hls.js errors and native <video> errors, and console.error logging of the technical detail. Confirmed working live during testing - a real hls.js fatal error (no live Emby stream available in the test environment) was caught and displayed correctly instead of failing silently. This is meant to turn "the player doesn't work" into an actual diagnosable error message next time it happens for real. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-09-13 22:57:06 +02:00
Nicolas	f563f5b0a2	Emby-style UI: sidebar, carousels, series drill-down, episode queue, player tracks ... Big UI pass towards looking/behaving like Emby. Deferred: music (needs its own player + a real-time collaborative playlist - different enough subsystem to be its own pass; sidebar/routing already treat it as a first-class collectionType, page just says "not yet" for now). Layout: - client/js/shell.js: persistent sidebar (one entry per Emby library, from GET /api/catalog/libraries which now also returns collectionType) + a #mainContent the router swaps on navigation. router.js made idempotent (start() safe to call more than once) so a login -> shell boot can happen twice in one page lifetime (logout then back in) without piling up duplicate hashchange listeners. - app.js's boot() renders either the bare login screen or the full shell depending on session state; login.js calls it again on success instead of navigate() (no router running yet at that point). Browsing, by collection type: - views/home.js (route /home): a carousel of every active party server-wide, a join-by-code fallback, then one "recently added" carousel per non-music library (GET /api/catalog/libraries/:id/recent, Emby's Items/Latest). - views/library.js (route /library/:id): dispatches on collectionType - movies/tvshows get the tile grid (Series tiles link into /series/:id instead of starting a party directly), music gets an honest placeholder. - views/series.js (route /series/:id): season tabs + episode list (new GET /api/catalog/series/:id/seasons and .../episodes, Emby's /Shows/{id}/Seasons and /Episodes). - tiles.js: poster-tile rendering shared by home.js and library.js so they can't drift apart. Episode queue / "next episode": - POST /api/parties now builds a queue when starting from an episode (fetches the rest of the series, from that episode onward) - partyManager.js gained queue/queueIndex/advanceQueue. - New WS message {type:"next"} (host-only) advances the queue and broadcasts {type:"itemChanged", itemId, itemName, ...}; every client reloads the player against the new item. player.js shows "Épisode suivant" when hasNext, and auto-sends next() on the video's `ended` event. Player: language/subtitles/quality: - New GET /api/catalog/item/:id/playback-options exposes PlaybackInfo's MediaStreams as audio/subtitle track lists. - master.m3u8 now forwards AudioStreamIndex/SubtitleStreamIndex/ MaxStreamingBitrate to PlaybackInfo; player.js has three <select>s (host-only) that reload the stream at the same position on change. Subtitles end up burned into the transcode (via SubtitleStreamIndex), not a toggleable track - simpler than sidecar WebVTT for this pass. "Quality" is a MaxStreamingBitrate ceiling, not true adaptive bitrate. Verified by driving a browser against mocked /api/* responses (see session history): sidebar renders/highlights correctly, home carousels render (parties + one row per non-music library, music correctly skipped), library grid dispatch works, series page season-tab switching + episode list render and the season/episode navigation flow works end to end. Real Emby response shapes for all of this (Views' CollectionType, Seasons/Episodes, Items/Latest, PlaybackInfo's MediaStreams) and the queue/track-picker protocol are NOT yet confirmed against a live server - see docs/architecture.md. Removed client/js/views/browse.js, superseded by home.js + library.js. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-09-13 22:44:49 +02:00
Nicolas	07613c1cec	Redesign home page: library tabs, poster tiles, ongoing parties list ... - New backend endpoints: GET /api/catalog/libraries (Emby's /Users/{id}/Views), GET /api/catalog/libraries/:id/items (top-level, Recursive=false - movies as movies, TV as Series tiles), GET /api/parties (list every active party server-wide, for the home page's "watch parties en cours" section) - Item DTO gained `type` and `canWatchParty` (only Movie/Episode/Video are directly streamable - a Series tile only gets "Voir sur Emby") and `embyUrl`, a deep link into Emby's own web client built from EMBY_SERVER_URL + serverId (now captured at login) - Party creation now fetches and stores the item's name/poster so the home page's party list doesn't need a separate lookup per party - client/js/views/browse.js rewritten: ongoing-parties section, a join-by-code fallback, one tab per library, and a tile grid with a hover-revealed two-button overlay (start party / view on Emby) - the first only shown for playable types - Removed itemDetail.js/the /item/:id route (tiles act directly now, no intermediate detail page); player.js simplified to use party.itemName instead of a redundant item lookup - app.css: full-width home layout (no max-width cap, as asked), CSS grid handling all the responsive reflow, :hover/:focus-within reveal for the tile overlay with an always-visible (hover: none) fallback for touch devices Verified by actually driving a browser (mocked fetch standing in for /api/parties and /api/catalog/* - real login still needs real credentials): tab switching swaps content correctly, the overlay reveals per-tile only, a Series tile correctly omits the watch-party button, and the touch fallback shows both buttons inline without hover. See docs/architecture.md for exactly what that does and doesn't confirm (real Emby /Views and item-list response shapes are still unverified). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-09-13 21:54:14 +02:00
Nicolas	b6818655b1	Proxy all Emby access through our own backend; drop server-url field; use Emby's real theme colors ... Three changes requested: 1. Server proxies Emby, browser never talks to it directly. Login is now POST /api/auth/login {username,password} on our own backend; the backend calls Emby's AuthenticateByName server-side and mints its own opaque session (httpOnly cookie), storing {embyToken,userId,userName} in memory. The browser never sees or holds a real Emby access token. Every other call - search, item details, images, HLS streaming, party actions - goes to our own /api/* origin, authenticated by that cookie; server/src/embyProxy.js forwards to Emby server-side and streams the response back (including a playlist-rewrite pass for HLS .m3u8 so hls.js never gets handed a URL pointing at Emby directly). This also sidesteps the CORS problem the previous direct-to-Emby design had. 2. EMBY_SERVER_URL is backend-only config (.env.example); the login form no longer asks for a server address at all. 3. client/css/app.css now uses colors read directly off the live Emby server's own dark theme (--theme-primary-color-* etc, fetched via a JS probe against the running client, not guessed): accent green #52b54b/#6ccf65, near-black background #151216. Tested for real: ran the server locally against the actual EMBY_SERVER_URL and submitted intentionally-wrong credentials through the UI - confirmed the full round trip (browser -> our backend -> real Emby -> real 401 -> our error message) with no CORS issue, since it's all server-to-server now. Login itself hasn't been exercised with real credentials, so catalog/streaming remain unverified - see docs/architecture.md. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-09-13 21:36:26 +02:00
Nicolas	6ff9aa29e2	Pivot to a standalone app - Emby plugin hit a hard wall ... No plugin API exists for adding a button to Emby's player or item detail page (confirmed by an Emby developer on their own forum, and by research since). The only way to reach that would be patching Emby's shipped web client files directly - outside the plugin, breaks on every image update, needs manual reapplication. Not worth the ongoing cost, per discussion. New direction: a standalone app with its own player. Reads Emby's catalog/streams directly from the browser (no plugin, no menu integration fights); a small Node backend only coordinates party membership and relays playback state over WebSocket - it never touches a media byte. Auth is Emby-only, as chosen: the browser signs in against Emby directly and this backend validates whatever token it gets handed by asking Emby itself (GET /Users/{userId}), never seeing a password. Control model changed too: now that we own the player, host controls playback and everyone else follows (event-driven play/pause/seek + a 3s heartbeat, drift-corrected on the follower side) - the old plugin's "everyone keeps their own controls, shared reference position" was specifically a concession to nudging pre-existing Emby app sessions we didn't control, which no longer applies. - server/: Express + ws backend (party lifecycle, WebSocket protocol, Emby token validation) - client/: plain-JS/ES-modules frontend (login, search, item detail, party player) - no build step - Smoke-tested locally end to end against a stubbed Emby URL: server starts, routing/auth-gating works, error handling degrades gracefully (network failure, invalid token) - see the session transcript for the actual browser test run - docs/architecture.md rewritten around the new design, including why the plugin was abandoned and a fresh "assumptions to verify" list (CORS between this app's origin and Emby's is the biggest unknown) - src/WatchParty/ (the Emby plugin) kept as-is for reference, no longer the active direction Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-09-13 20:48:55 +02:00